Skip to content

Hdds 1651#928

Closed
shwetayakkali wants to merge 3 commits intoapache:trunkfrom
shwetayakkali:HDDS-1651
Closed

Hdds 1651#928
shwetayakkali wants to merge 3 commits intoapache:trunkfrom
shwetayakkali:HDDS-1651

Conversation

@shwetayakkali
Copy link

@shwetayakkali shwetayakkali commented Jun 7, 2019

Ozone currently uses dfs.http.policy for HTTP policy. Ozone should have its own ozone.http.policy configuration

shwetayakkali@cloudera.com added 3 commits June 6, 2019 11:50
HDFS-14487.Missing Space in Client Error Message
7d4897f 
Change-Id: I94ac5ebb220fb7e46d55bccf499c3e4a8f84e677
HDFS-14494. Move Server logging of StatedId inside receiveRequestState()
4633312 
Change-Id: I14b5a0c1683d0750130c9186c1b21bfdae531db3
HADOOP-16156. [Clean-up] Remove NULL check before instanceof and fix …
33daf39 
…checkstyle in InnerNodeImpl

Change-Id: Ie9d3866e88b067c55a955fbb005a8c3460517338
@hadoop-yetus
Copy link

hadoop-yetus commented Jun 8, 2019

💔 -1 overall

Vote Subsystem Runtime Comment
0 reexec 68 Docker mode activated.
_ Prechecks _
+1 dupname 0 No case conflicting files found.
+1 @author 0 The patch does not contain any @author tags.
-1 test4tests 0 The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
0 mvndep 202 Maven dependency ordering for branch
+1 mvninstall 1095 trunk passed
+1 compile 958 trunk passed
+1 checkstyle 147 trunk passed
+1 mvnsite 205 trunk passed
+1 shadedclient 1103 branch has no errors when building and testing our client artifacts.
+1 javadoc 163 trunk passed
0 spotbugs 185 Used deprecated FindBugs config; considering switching to SpotBugs.
+1 findbugs 473 trunk passed
_ Patch Compile Tests _
0 mvndep 60 Maven dependency ordering for patch
+1 mvninstall 178 the patch passed
+1 compile 1142 the patch passed
+1 javac 1142 the patch passed
+1 checkstyle 159 root: The patch generated 0 new + 230 unchanged - 15 fixed = 230 total (was 245)
+1 mvnsite 228 the patch passed
+1 whitespace 0 The patch has no whitespace issues.
+1 shadedclient 813 patch has no errors when building and testing our client artifacts.
+1 javadoc 154 the patch passed
+1 findbugs 437 the patch passed
_ Other Tests _
+1 unit 536 hadoop-common in the patch passed.
+1 unit 117 hadoop-hdfs-client in the patch passed.
-1 unit 5730 hadoop-hdfs in the patch failed.
+1 asflicense 50 The patch does not generate ASF License warnings.
13936
Reason Tests
Failed junit tests hadoop.hdfs.server.namenode.ha.TestDFSUpgradeWithHA
Subsystem Report/Notes
Docker Client=18.09.5 Server=18.09.5 base: https://builds.apache.org/job/hadoop-multibranch/job/PR-928/1/artifact/out/Dockerfile
GITHUB PR #928
Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
uname Linux 72dcde8813ab 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 08:28:49 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
Build tool maven
Personality personality/hadoop.sh
git revision trunk / 76b94c2
Default Java 1.8.0_212
unit https://builds.apache.org/job/hadoop-multibranch/job/PR-928/1/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
Test Results https://builds.apache.org/job/hadoop-multibranch/job/PR-928/1/testReport/
Max. process+thread count 2916 (vs. ulimit of 5500)
modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-client hadoop-hdfs-project/hadoop-hdfs U: .
Console output https://builds.apache.org/job/hadoop-multibranch/job/PR-928/1/console
versions git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1
Powered by Apache Yetus 0.10.0 http://yetus.apache.org

This message was automatically generated.

shanthoosh pushed a commit to shanthoosh/hadoop that referenced this pull request Oct 15, 2019
@atoomula
SAMZA-1990: Samza framework should let using the same system stream a…
5fcfc95 
…s both input and output.

**Symptom:** An `IllegalArgumentException` is thrown when the same `streamId` is referred from multiple input/output stream descriptors.
**Cause:** The `ApplicationDescriptorImpl` caches the serde instances for streams by a `streamId` and there's a check to ensure the expected stream serde matches when using the same stream from multiple input/output descriptors. However the check is incorrect because it compares serde instances and not serde types. This check always fails in this scenario.
**Fix:** Compare the stream serdes for a particular `streamId` by type.

Please take a look prateekm nickpan47
CC: atoomula

Author: Daniel Nishimura <dnishimura@linkedin.com>

Reviewers: prateekm

Closes apache#928 from dnishimura/samza-1990-same-stream-different-inputoutputdescriptors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shwetayakkali @hadoop-yetus